chore: configuration for docs-preview #1518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seyhello
commented
Apr 1, 2025
•
seyhello
commented
- nginx configuration for apify-docs-preview - everything pointed to *.preview.docs.apify.com domain will be redirected to the apify-docs-preview S3 bucket directly. It will be used for "staging/preview" documentation
seyhello
added
adhoc
github-actions
bot
added
the
t-platform
|
@seyhello I have zero context for this, could you give me some? |
fnesveda
requested changes
Apr 8, 2025
| server_name ~^(?<subdomain>[^.]+)\.preview\.docs\.apify\.com$; | ||
|
|
||
| location / { | ||
| rewrite ^/(.*)/$ https://s3.amazonaws.com/apify-docs-preview/$subdomain/$1/index.html permanent; |
There was a problem hiding this comment.
As discussed in person - let's try to use proxy_pass here so that it doesn't require enabling public read on the bucket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.