This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Finished scheme support #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
force-pushed
the
pksunkara/security
branch
from
b2344a5 to
11523ad
Compare
pksunkara
changed the title
pksunkara
force-pushed
the
pksunkara/security
branch
2 times, most recently
from
186bca8 to
a3cb6b5
Compare
kylef
reviewed
Apr 3, 2019
packages/fury-adapter-oas3-parser/lib/parser/oas/parseOauthFlowObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseSecuritySchemeObject.js
Outdated
Show resolved
Hide resolved
packages/minim-api-description/lib/elements/http-transaction.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseOauthFlowsObject-test.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseOauthFlowsObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseOperationObject.js
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseSecurityRequirementObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseSecuritySchemeObject.js
Show resolved
Hide resolved
pksunkara
force-pushed
the
pksunkara/security
branch
3 times, most recently
from
1dc1247 to
644185d
Compare
pksunkara
commented
Jul 30, 2019
packages/fury-adapter-oas3-parser/lib/parser/oas/parseSecurityRequirementObject.js
Show resolved
Hide resolved
kylef
reviewed
Jul 30, 2019
packages/fury-adapter-oas3-parser/lib/parser/oas/parseOperationObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseOauthFlowObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseOperationObject.js
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseSecuritySchemeObject.js
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseComponentsObject.js
Outdated
Show resolved
Hide resolved
pksunkara
force-pushed
the
pksunkara/security
branch
2 times, most recently
from
677d8f2 to
723eac0
Compare
I want to do this in a separate PR. Also, security scheme (does it exist?) validation is not done since it's tied into the above. The splitting of oauth2 schemes into different flows when we encounter them in security requirements is also not done since it is also tied into the above 2 things that are pending. |
kylef
suggested changes
Aug 9, 2019
packages/fury-adapter-oas3-parser/lib/parser/oas/parseOpenAPIObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseOperationObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseSecuritySchemeObject-test.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseSecuritySchemeObject-test.js
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseSecuritySchemeObject-test.js
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseSecuritySchemeObject-test.js
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/lib/parser/oas/parseSecuritySchemeObject.js
Outdated
Show resolved
Hide resolved
packages/fury-adapter-oas3-parser/test/unit/parser/oas/parseSecurityRequirementObject-test.js
Show resolved
Hide resolved
pksunkara
force-pushed
the
pksunkara/security
branch
from
98e4341 to
d0f39a9
Compare
Co-Authored-By: Kyle Fuller <[email protected]>
pksunkara
force-pushed
the
pksunkara/security
branch
from
d0f39a9 to
1587583
Compare
kylef
approved these changes
Aug 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the full support for oauth2 flows (after the breaking change in the Oauth2 Scheme element)
UPDATED: No more breaking changes (Spec PR)