feat: adding external ref openapi examples and adding it to some rules #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
devdevx
requested changes
Apr 28, 2025
| @@ -7,12 +7,6 @@ | |||
| "paths" : { | |||
| "/pets" : { | |||
| "get" : { | |||
| "requestBody" : { | |||
There was a problem hiding this comment.
why are we losing this errors?
| } | ||
| } | ||
|
|
||
| if (node.getType() == OpenApi3Grammar.OPERATION) { |
There was a problem hiding this comment.
we are subscribed now to OpenApi3Grammar.PATH, why we don't have an if for that case?
| @@ -104,8 +105,14 @@ private void visitV3Node(JsonNode node) { | |||
| List<JsonNode> responseCodes = node.properties().stream().collect(Collectors.toList()); | |||
| for (JsonNode jsonNode : responseCodes) { | |||
| if (!jsonNode.key().getTokenValue().equals("204")) { | |||
| JsonNode responseNode = jsonNode.resolve(); | |||
| visitContentNode(responseNode); | |||
| boolean externalRefManagement = false; | |||
| @@ -66,8 +66,14 @@ private void visitV3Node(JsonNode node) { | |||
| List<JsonNode> responseCodes = node.properties().stream().collect(Collectors.toList()); | |||
| for (JsonNode jsonNode : responseCodes) { | |||
| if (!jsonNode.key().getTokenValue().equals("204")) { | |||
| JsonNode responseNode = jsonNode.resolve(); | |||
| visitContentNode(responseNode); | |||
| boolean externalRefManagement = false; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding external ref to rules OAR006,007,009,010 and 044.
Some expamples too.