Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to ESLint v9 #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat!: upgrade to ESLint v9 #109

wants to merge 1 commit into from

Conversation

dcroote
Copy link
Collaborator

@dcroote dcroote commented Feb 19, 2025

Closes #108, supersedes #6, #9, and #98. This will require bumping ESLint for all consumers, but since v8 was end of life October 2024, it seems like it's time.

There is one warning on install:

 WARN  Issues with peer dependencies found
.
└─┬ @shopify/eslint-plugin 47.0.1
  └── ✕ unmet peer eslint@^8.56.0: found 9.20.1

However it seems like it's OK.

@dcroote dcroote requested a review from Siegrift February 19, 2025 06:59
@dcroote dcroote self-assigned this Feb 19, 2025
Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dcroote
Copy link
Collaborator Author

dcroote commented Feb 20, 2025

Ugh this was too optimistic. All the src/ configs need to be converted too. It's a mess with stupid commonjs & esm conflicts everywhere. I'm converting this repo to typescript and will dual export commonjs & esm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove eslint-plugin-deprecation
2 participants