Adds dappId
to combinator contracts
#29
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
Changes
dappId
immutable variable to all combinator contracts. These are set by reading the underlying proxy.dappId() (except for NormalizedApi3ReaderProxyV1)IApi3ReaderProxyV1
NormalizedApi3ReaderProxyV1
now requires adappId
to be pass in the constructorProductApi3ReaderProxyV1
MockApi3ReaderProxyV1
test contract to make testing simplerNotes
dappId()
inIApi3ReaderProxyV1
is not marked asview
IApi3ReaderProxyV1
still feels kind of wrong to me since the underlying proxies might be another combinator proxy which might not even expose adapiName()
function for example. I think it might be more accurate to create aIApi3ReaderProxyWithDappId
or similar that inherints fromIApi3ReaderProxy
and adds a functiondappId() external view returns (uint256);