Fix: generating iri cache tag for collection operation with path para… #7152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
May 16, 2025
| @@ -111,14 +111,13 @@ public function postFlush(): void | |||
| private function gatherResourceAndItemTags(object $entity, bool $purgeItem): void | |||
| { | |||
| try { | |||
| $resourceClass = $this->resourceClassResolver->getResourceClass($entity); | |||
| $iri = $this->iriConverter->getIriFromResource($resourceClass, UrlGeneratorInterface::ABS_PATH, new GetCollection()); | |||
| $iri = $this->iriConverter->getIriFromResource($entity, UrlGeneratorInterface::ABS_PATH, new GetCollection()); | |||
There was a problem hiding this comment.
the patch looks fine though we should add some non-regression test
There was a problem hiding this comment.
the patch looks fine though we should add some non-regression test
Can you give me some examples/pointers for non-regression tests? Do you need me to do those tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Generating IRI Cache Tag for collection operation with path parameter
This pull request addresses an issue in the PurgeHttpCacheListener where the IRI cache tag for collection operations was not being generated when path parameters were involved.
Changes:
Simplified Use Case:
Consider an entity A with a OneToMany relationship to entity B. The collection operation URI template for entity B might look like /a/{id}/b. Since entity B is only relevant in the context of its parent entity A, when updating A, we want to purge the cache using the tag /a/{id}/b instead of /b. This ensures that we avoid purging cache for all responses containing B tags, maintaining more precise cache invalidation.