Skip to content

Commit

Permalink
handshake: ignore unknown QUIC events from crypto/tls (quic-go#4577)
Browse files Browse the repository at this point in the history
  • Loading branch information
marten-seemann authored Jun 28, 2024
1 parent 8f11104 commit 7379f1f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion internal/handshake/crypto_setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,10 @@ func (h *cryptoSetup) handleEvent(ev tls.QUICEvent) (done bool, err error) {
h.handshakeComplete()
return false, nil
default:
return false, fmt.Errorf("unexpected event: %d", ev.Kind)
// Unknown events should be ignored.
// crypto/tls will ensure that this is safe to do.
// See the discussion following https://github.com/golang/go/issues/68124#issuecomment-2187042510 for details.
return false, nil
}
}

Expand Down

0 comments on commit 7379f1f

Please sign in to comment.