fix: fix duplicate 'mysql' database issue #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #283 Exclude the 'mysql' database from the `AllDatabases` method in `catalog/provider.go`. * Add a condition to filter out the 'mysql' database in the switch statement. By GitHub Copilot Workspace --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/apecloud/myduckserver/issues/283?shareId=XXXX-XXXX-XXXX-XXXX).
… BATS test to ensure unique databases
* **catalog/provider.go**
- Add a condition to filter out the 'mysql' database in the `AllDatabases` method
* **test/bats/mysql/unique_databases.bats**
- Add a BATS test to ensure every database reported by `SHOW DATABASES` is unique
- Replace `${MYSQL}` with `mysql -h 127.0.0.1 -u root`
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- test/bats/mysql/unique_databases.bats: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283
Exclude the 'mysql' database from the
AllDatabasesmethod incatalog/provider.go.By GitHub Copilot Workspace
For more details, open the Copilot Workspace session.