feat: support for ALTER/DROP SUSCRIPTION
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang01
reviewed
Dec 6, 2024
| ValueColumns: []string{"connection", "publication"}, | ||
| DDL: "name TEXT PRIMARY KEY, connection TEXT, publication TEXT", | ||
| KeyColumns: []string{"subname"}, | ||
| ValueColumns: []string{"subconninfo", "subpublication", "subskiplsn", "subenabled"}, |
There was a problem hiding this comment.
The sub prefix for all column names can be removed.
There was a problem hiding this comment.
sub is chosen to maintain consistency with the pg_subscription catalog in PostgreSQL.
pgserver/connection_handler.go
Outdated
| @@ -1059,15 +1059,15 @@ func (h *ConnectionHandler) handledPSQLCommands(statement string) (bool, error) | |||
| statement = strings.ToLower(statement) | |||
| // Command: \l | |||
| if statement == "select d.datname as \"name\",\n pg_catalog.pg_get_userbyid(d.datdba) as \"owner\",\n pg_catalog.pg_encoding_to_char(d.encoding) as \"encoding\",\n d.datcollate as \"collate\",\n d.datctype as \"ctype\",\n d.daticulocale as \"icu locale\",\n case d.datlocprovider when 'c' then 'libc' when 'i' then 'icu' end as \"locale provider\",\n pg_catalog.array_to_string(d.datacl, e'\\n') as \"access privileges\"\nfrom pg_catalog.pg_database d\norder by 1;" { | |||
| query, err := h.convertQuery(`select d.datname as "Name", 'postgres' as "Owner", 'UTF8' as "Encoding", 'en_US.UTF-8' as "Collate", 'en_US.UTF-8' as "Ctype", 'en-US' as "ICU Locale", case d.datlocprovider when 'c' then 'libc' when 'i' then 'icu' end as "locale provider", '' as "access privileges" from pg_catalog.pg_database d order by 1;`) | |||
| query, err := h.convertQuery(`select d.datname as "Subscription", 'postgres' as "Owner", 'UTF8' as "Encoding", 'en_US.UTF-8' as "Collate", 'en_US.UTF-8' as "Ctype", 'en-US' as "ICU Locale", case d.datlocprovider when 'c' then 'libc' when 'i' then 'icu' end as "locale provider", '' as "access privileges" from pg_catalog.pg_database d order by 1;`) | |||
| Enabled: enabled, | ||
| Replicator: nil, | ||
| } | ||
| } |
There was a problem hiding this comment.
Check rows.Err() after the for loop.
pgserver/logrepl/subscription.go
Outdated
| var lsnValueColumns = []string{"subskiplsn"} | ||
|
|
||
| var subscriptionMap = sync.Map{} | ||
| var mu sync.Mutex |
There was a problem hiding this comment.
Unnecessary and dangerous global mutex.
pgserver/logrepl/subscription.go
Outdated
| } | ||
| defer rows.Close() | ||
|
|
||
| if !rows.Next() { | ||
| return | ||
| var tempMap = make(map[string]*Subscription) |
There was a problem hiding this comment.
The temp prefix is unnecessary. It is a local variable, implying it is temporary.
pgserver/subscription_handler.go
Outdated
| subscriptionName := subscriptionMatch[1] | ||
| connectionString := subscriptionMatch[2] | ||
| publicationName := subscriptionMatch[3] | ||
| func (h *ConnectionHandler) executeAlterEnable(subscriptionConfig *SubscriptionConfig) error { |
There was a problem hiding this comment.
executeAlterEnable -> executeEnableSubscription(config *SubscriptionConfig)
pgserver/subscription_handler.go
Outdated
| return commitAndUpdate(sqlCtx) | ||
| } | ||
|
|
||
| func (h *ConnectionHandler) executeAlterDisable(subscriptionConfig *SubscriptionConfig) error { |
There was a problem hiding this comment.
-> executeDisableSubscription(config *SubscriptionConfig)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #246
New Features
ALTER SUBSCRIPTION:
Added support for
ALTER SUBSCRIPTION mysub [ENABLE | DISABLE].DISABLE: Pauses replication from the source PostgreSQL.ENABLE: Resumes replication from the source PostgreSQL.DROP SUBSCRIPTION:
Added support for
DROP SUBSCRIPTION mysub.Note: Dropping a subscription does not remove any previously replicated data.
Improvements
subscriptionMapinsubscription.goto manage all subscriptions centrally.__sys__.pg_replication_lsninto__sys__.pg_subscription.