Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translate LOAD DATA for DuckDB #100

Merged
merged 4 commits into from
Oct 18, 2024
Merged

feat: translate LOAD DATA for DuckDB #100

merged 4 commits into from
Oct 18, 2024

Conversation

fanyang01
Copy link
Collaborator

@fanyang01 fanyang01 commented Oct 17, 2024

This PR implements the fast path proposed in #69.

Copy link
Contributor

@TianyuZhang1214 TianyuZhang1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fanyang01
Copy link
Collaborator Author

Note that DuckDB's behavior can be different from MySQL if the
data contains special characters: duckdb/duckdb#14434

Let's use DuckDB aggressively for now and find a way to resolve the above issue in the future.

@fanyang01 fanyang01 merged commit 9e38711 into main Oct 18, 2024
1 check passed
TianyuZhang1214 pushed a commit that referenced this pull request Oct 22, 2024
* Translate LOAD DATA for DuckDB
* Skip the test of fewer columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants