Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wait for container ready at least for minReadySeconds when doing image rolling update #8415

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Nov 6, 2024

No description provided.

@free6om free6om added this to the Release 0.9.2 milestone Nov 6, 2024
@free6om free6om self-assigned this Nov 6, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 65.00%. Comparing base (692a5a2) to head (69aafde).
Report is 1 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controller/instanceset/instance_util.go 33.33% 5 Missing and 3 partials ⚠️
pkg/controller/instanceset/reconciler_update.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8415      +/-   ##
===============================================
+ Coverage        64.87%   65.00%   +0.12%     
===============================================
  Files              358      358              
  Lines            45424    45438      +14     
===============================================
+ Hits             29470    29537      +67     
+ Misses           13336    13289      -47     
+ Partials          2618     2612       -6     
Flag Coverage Δ
unittests 65.00% <26.66%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 6, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Nov 6, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 6, 2024
@wangyelei wangyelei merged commit cd4b7e0 into release-0.9 Nov 7, 2024
37 checks passed
@wangyelei wangyelei deleted the support/image-rolling-update-waits-for-container-ready-0.9 branch November 7, 2024 01:24
free6om added a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants