Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refine the labels and annotations #8178

Merged
merged 13 commits into from
Sep 24, 2024
Merged

chore: refine the labels and annotations #8178

merged 13 commits into from
Sep 24, 2024

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Sep 20, 2024 •
edited
Loading

  1. Remove the component-replicas annotation key from Pods
  2. Change the value of generation patched to ITS objects from Cluster to Component
  3. Pass the cluster uuid through a new cluster-uid annotation key

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 20, 2024
@leon-inf leon-inf force-pushed the support/refine-labels-and-annotations branch from c270597 to 2ad939f Compare September 20, 2024 09:42
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.80488% with 20 lines in your changes missing coverage. Please review.

Project coverage is 61.08%. Comparing base (890220d) to head (959e22d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/component/component.go 60.71% 9 Missing and 2 partials ⚠️
...rollers/apps/transformer_cluster_shared_account.go 0.00% 4 Missing ⚠️
pkg/controller/component/workload_utils.go 20.00% 4 Missing ⚠️
controllers/apps/transformer_component_status.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8178      +/-   ##
==========================================
- Coverage   61.15%   61.08%   -0.08%     
==========================================
  Files         354      354              
  Lines       40969    40908      -61     
==========================================
- Hits        25054    24988      -66     
- Misses      13654    13655       +1     
- Partials     2261     2265       +4
Flag Coverage Δ
unittests 61.08% <87.80%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Sep 21, 2024
@leon-inf leon-inf changed the title chore: refine the labels and annotations chore: refine the annotations of component and its objects Sep 21, 2024
@leon-inf leon-inf changed the title chore: refine the annotations of component and its objects chore: refine the annotations of component and ITS objects Sep 21, 2024
@leon-inf leon-inf changed the title chore: refine the annotations of component and ITS objects chore: refine the annotations of Component and ITS objects Sep 21, 2024
@leon-inf leon-inf marked this pull request as ready for review September 21, 2024 04:03
@leon-inf leon-inf force-pushed the support/refine-labels-and-annotations branch from 0c220eb to a6da8f8 Compare September 21, 2024 04:26
zjx20
zjx20 reviewed Sep 23, 2024
View reviewed changes
pkg/controller/component/type.go
Comp2CompDefs map[string]string `json:"comp2CompDefs,omitempty"` // {compName: compDefName}
Name string `json:"name,omitempty"` // the name of the component w/o clusterName prefix
FullCompName string `json:"fullCompName,omitempty"` // the full name of the component w/ clusterName prefix
CompDefName string `json:"compDefName,omitempty"` // the name of the componentDefinition
Generation string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why some fields don't have JSON tags defined. This feels like a code smell.

@leon-inf leon-inf changed the title chore: refine the annotations of Component and ITS objects chore: refine the annotations Sep 23, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 23, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Sep 23, 2024
@github-actions github-actions bot removed the size/L Denotes a PR that changes 100-499 lines. label Sep 23, 2024
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Sep 23, 2024
@leon-inf leon-inf changed the title chore: refine the annotations chore: refine the labels and annotations Sep 23, 2024
@leon-inf leon-inf force-pushed the support/refine-labels-and-annotations branch from 1b51e91 to b946529 Compare September 24, 2024 03:08
@leon-inf
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 24, 2024
@leon-inf leon-inf merged commit e6cf971 into main Sep 24, 2024
35 checks passed
@leon-inf leon-inf deleted the support/refine-labels-and-annotations branch September 24, 2024 06:07
@github-actions github-actions bot added this to the Release 0.9.2 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@zjx20 zjx20 zjx20 approved these changes

@sophon-zt sophon-zt Awaiting requested review from sophon-zt sophon-zt is a code owner

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie Y-Rookie is a code owner

@ldming ldming Awaiting requested review from ldming ldming is a code owner

@wangyelei wangyelei Awaiting requested review from wangyelei wangyelei is a code owner

Assignees
No one assigned
Labels
approved PR Approved Test size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
Release 0.9.2
Development

Successfully merging this pull request may close these issues.
3 participants
@leon-inf @zjx20 @apecloud-bot