Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Reconciliation View #8143

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Sep 12, 2024

No description provided.

@free6om free6om added this to the Release 1.0.0 milestone Sep 12, 2024
@free6om free6om self-assigned this Sep 12, 2024
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Sep 12, 2024
@free6om
Copy link
Contributor Author

free6om commented Sep 12, 2024

why use the two markers:

// +kubebuilder:pruning:PreserveUnknownFields
// +kubebuilder:validation:Schemaless

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 99 lines in your changes missing coverage. Please review.

Project coverage is 62.24%. Comparing base (80d091a) to head (b37bc81).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
controllers/view/reconciliationview_controller.go 0.00% 57 Missing ⚠️
controllers/view/object_store.go 0.00% 11 Missing ⚠️
controllers/view/object_tree_root_finder.go 0.00% 11 Missing ⚠️
controllers/view/informer_manager.go 0.00% 10 Missing ⚠️
controllers/view/reconciliationplan_controller.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8143      +/-   ##
==========================================
- Coverage   62.42%   62.24%   -0.19%     
==========================================
  Files         333      338       +5     
  Lines       40572    40671      +99     
==========================================
- Hits        25326    25314      -12     
- Misses      12984    13085     +101     
- Partials     2262     2272      +10     
Flag Coverage Δ
unittests 62.24% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant