Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to update opsrequest (#4951) #4965

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt linked an issue Sep 1, 2023 that may be closed by this pull request
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 1, 2023
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (b7ac16d) 66.96% compared to head (ceb89e1) 66.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4965      +/-   ##
==========================================
- Coverage   66.96%   66.93%   -0.03%     
==========================================
  Files         265      265              
  Lines       31986    31992       +6     
==========================================
- Hits        21418    21415       -3     
- Misses       8707     8713       +6     
- Partials     1861     1864       +3     
Flag Coverage Δ
unittests 66.93% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
controllers/apps/operations/reconfigure_util.go 74.64% <100.00%> (ø)
internal/configuration/core/config_util.go 78.08% <100.00%> (+1.96%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt merged commit 1b7a59b into main Sep 4, 2023
99 checks passed
@sophon-zt sophon-zt deleted the bugfix/enable-all-logs-failed-for-failed-to-update-param-issue4951 branch September 4, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]enable-all-logs failed for failed to update param
4 participants