feat: add completion timestamp for bench (#67)

api/v1alpha1/fio_types.go

@@ -106,6 +106,9 @@ type FioStatus struct {
 	// total is the number of pgbench runs
 	Total int `json:"total,omitempty"`
 
+	// the completion timestamp of the test
+	CompletionTimestamp *metav1.Time `json:"completionTimestamp,omitempty"`
+
 	// Describes the current state of benchmark conditions.
 	// +optional
 	Conditions []metav1.Condition `json:"conditions,omitempty"`

api/v1alpha1/pgbench_types.go

@@ -98,6 +98,9 @@ type PgbenchStatus struct {
 	// Describes the current state of benchmark conditions.
 	// +optional
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
+
+	// the completion timestamp of the test
+	CompletionTimestamp *metav1.Time `json:"completionTimestamp,omitempty"`
 }
 
 // +kubebuilder:object:root=true

api/v1alpha1/redisbench_types.go

@@ -79,6 +79,9 @@ type RedisBenchStatus struct {
 	// Describes the current state of benchmark conditions.
 	// +optional
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
+
+	// the completion timestamp of the test
+	CompletionTimestamp *metav1.Time `json:"completionTimestamp,omitempty"`
 }
 
 // +kubebuilder:object:root=true

api/v1alpha1/sysbench_types.go

@@ -66,6 +66,9 @@ type SysbenchStatus struct {
 	// Describes the current state of benchmark conditions.
 	// +optional
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
+
+	// the completion timestamp of the test
+	CompletionTimestamp *metav1.Time `json:"completionTimestamp,omitempty"`
 }
 
 //+kubebuilder:object:root=true

api/v1alpha1/tpcc_types.go

@@ -111,6 +111,9 @@ type TpccStatus struct {
 	// Describes the current state of benchmark conditions.
 	// +optional
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
+
+	// the completion timestamp of the test
+	CompletionTimestamp *metav1.Time `json:"completionTimestamp,omitempty"`
 }
 
 //+kubebuilder:object:root=true

api/v1alpha1/tpcds_types.go

@@ -57,6 +57,9 @@ type TpcdsStatus struct {
 	// Describes the current state of benchmark conditions.
 	// +optional
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
+
+	// the completion timestamp of the test
+	CompletionTimestamp *metav1.Time `json:"completionTimestamp,omitempty"`
 }
 
 //+kubebuilder:object:root=true

api/v1alpha1/tpch_types.go

@@ -52,6 +52,9 @@ type TpchStatus struct {
 	// Describes the current state of benchmark conditions.
 	// +optional
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
+
+	// the completion timestamp of the test
+	CompletionTimestamp *metav1.Time `json:"completionTimestamp,omitempty"`
 }
 
 //+kubebuilder:object:root=true

api/v1alpha1/ycsb_types.go

@@ -123,6 +123,9 @@ type YcsbStatus struct {
 	// Describes the current state of benchmark conditions.
 	// +optional
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
+
+	// the completion timestamp of the test
+	CompletionTimestamp *metav1.Time `json:"completionTimestamp,omitempty"`
 }
 
 //+kubebuilder:object:root=true

config/crd/bases/benchmark.apecloud.io_fios.yaml

@@ -98,6 +98,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

config/crd/bases/benchmark.apecloud.io_pgbenches.yaml

@@ -138,6 +138,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

config/crd/bases/benchmark.apecloud.io_redisbenches.yaml

@@ -136,6 +136,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

config/crd/bases/benchmark.apecloud.io_sysbenches.yaml

@@ -131,6 +131,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

config/crd/bases/benchmark.apecloud.io_tpccs.yaml

@@ -157,6 +157,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

config/crd/bases/benchmark.apecloud.io_tpcds.yaml

@@ -117,6 +117,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

config/crd/bases/benchmark.apecloud.io_tpches.yaml

@@ -114,6 +114,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

config/crd/bases/benchmark.apecloud.io_ycsbs.yaml

@@ -174,6 +174,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

deploy/helm/crds/benchmark.apecloud.io_fios.yaml

@@ -98,6 +98,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

deploy/helm/crds/benchmark.apecloud.io_pgbenches.yaml

@@ -138,6 +138,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

deploy/helm/crds/benchmark.apecloud.io_redisbenches.yaml

@@ -136,6 +136,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

deploy/helm/crds/benchmark.apecloud.io_sysbenches.yaml

@@ -131,6 +131,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

deploy/helm/crds/benchmark.apecloud.io_tpccs.yaml

@@ -157,6 +157,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

deploy/helm/crds/benchmark.apecloud.io_tpcds.yaml

@@ -117,6 +117,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

deploy/helm/crds/benchmark.apecloud.io_tpches.yaml

@@ -114,6 +114,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

deploy/helm/crds/benchmark.apecloud.io_ycsbs.yaml

@@ -174,6 +174,9 @@ spec:
             type: object
           status:
             properties:
+              completionTimestamp:
+                format: date-time
+                type: string
               completions:
                 type: string
               conditions:

deploy/helm/values.yaml

@@ -9,7 +9,7 @@ image:
   pullPolicy: IfNotPresent
   registry: registry.cn-hangzhou.aliyuncs.com
   # Overrides the image tag whose default is the chart appVersion.
-  tag: "0.0.7"
+  tag: "0.0.8"
 
 imagePullSecrets: []
 nameOverride: ""

internal/controller/fio_controller.go

@@ -19,7 +19,9 @@ package controller
 import (
 	"context"
 	"fmt"
+	"time"
 
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/rest"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -76,6 +78,7 @@ func (r *FioReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
 
 	if fio.Status.Succeeded >= fio.Status.Total {
 		fio.Status.Phase = benchmarkv1alpha1.Completed
+		fio.Status.CompletionTimestamp = &metav1.Time{Time: time.Now()}
 	} else {
 		job := jobs[fio.Status.Succeeded]
 

internal/controller/pgbench_controller.go

@@ -20,7 +20,9 @@ import (
 	"context"
 	"fmt"
 	"strings"
+	"time"
 
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/rest"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -76,6 +78,7 @@ func (r *PgbenchReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 
 	if pgbench.Status.Succeeded >= pgbench.Status.Total {
 		pgbench.Status.Phase = benchmarkv1alpha1.Completed
+		pgbench.Status.CompletionTimestamp = &metav1.Time{Time: time.Now()}
 	} else {
 		job := jobs[pgbench.Status.Succeeded]
 

internal/controller/redisbench_controller.go

@@ -20,7 +20,9 @@ import (
 	"context"
 	"fmt"
 	"strings"
+	"time"
 
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/rest"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -77,6 +79,7 @@ func (r *RedisbenchReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 	if redisbench.Status.Succeeded >= redisbench.Status.Total {
 		l.Info("redisbench complete", "redisbench", redisbench.Name)
 		redisbench.Status.Phase = benchmarkv1alpha1.Completed
+		redisbench.Status.CompletionTimestamp = &metav1.Time{Time: time.Now()}
 	} else {
 		job := jobs[redisbench.Status.Succeeded]