feat(apalis-sql): add optional time crate support #655
+131
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Himmelschmidt
added a commit
to Himmelschmidt/apalis-postgres
that referenced
this pull request
Dec 26, 2025
- Add chrono/time feature flags for datetime library selection - Replace direct chrono usage with SqlDateTime and SqlDateTimeExt - Remove hardcoded chrono dependency in favor of feature-gated support - Update to apalis-sql path dependency for datetime abstraction Related to apalis-dev/apalis#655
Himmelschmidt
added a commit
to Himmelschmidt/apalis-mysql
that referenced
this pull request
Dec 26, 2025
Migrate to SqlDateTime/SqlDateTimeExt from apalis-sql instead of direct chrono/time usage. Adds migration to convert DATETIME columns to TIMESTAMP for proper UTC handling. Related to: apalis-dev/apalis#655
This was referenced Dec 26, 2025
geofmureithi
requested changes
Dec 26, 2025
Member
geofmureithi
left a comment
geofmureithi
left a comment
There was a problem hiding this comment.
TBH This looks neat 🚀
Just the small change to move it to its own module
You could also add some module level docs to explain the logic behind it.
geofmureithi
requested changes
Dec 26, 2025
Member
|
@Himmelschmidt |
Contributor
Author
|
I'll try to get this done over the next day or two |
Make chrono optional (still default) and add time crate as alternative datetime backend via feature flags.
Ensures --all-features works correctly in CI.
Aligns with sqlx behavior. Updates CI to require at least one datetime feature.
Adds SqlDateTimeExt extension trait that provides: - now() - returns current UTC datetime - to_unix_timestamp() - returns Unix timestamp This allows downstream crates to use `SqlDateTime::now()` without any conditional compilation, abstracting over chrono/time.
Adds from_unix_timestamp() method to convert Unix timestamps back to SqlDateTime, completing the bidirectional conversion API.
Address PR review feedback: - Rename sql_datetime module to datetime - Update module doc comment to "DateTime abstraction for unified time handling" - Remove unnecessary ignore from doc test - Fix clippy use_self warnings
Himmelschmidt
force-pushed
the
feat/time-support
branch
from
ad70b66 to
0af7ad7
Compare
Member
|
Contributor
Author
I ran |
geofmureithi
pushed a commit
to apalis-dev/apalis-postgres
that referenced
this pull request
Jan 8, 2026
* feat: use SqlDateTime abstraction from apalis-sql - Add chrono/time feature flags for datetime library selection - Replace direct chrono usage with SqlDateTime and SqlDateTimeExt - Remove hardcoded chrono dependency in favor of feature-gated support - Update to apalis-sql path dependency for datetime abstraction Related to apalis-dev/apalis#655 * chore: update apalis deps to git and add get_queue impl * bump: update apalis deps to rc.2 * chore: use crates.io deps instead of git * refactor: simplify get_queue impl * chore: update deps and changelog * revert: get_queue change * fix: use PgPool for PgContext type alias
Himmelschmidt
added a commit
to Himmelschmidt/apalis-sqlite
that referenced
this pull request
Jan 8, 2026
Replace direct chrono dependency with DateTime/DateTimeExt from apalis-sql, enabling support for both chrono and time datetime libraries via feature flags. Changes: - Add `chrono` (default) and `time` feature flags - Use DateTimeExt::from_unix_timestamp instead of chrono::Utc.timestamp_opt - Update apalis dependencies to 0.7.0-rc.2 - Move chrono to dev-dependencies (only needed for tests/examples) Related: apalis-dev/apalis#655
Himmelschmidt
added a commit
to Himmelschmidt/apalis-mysql
that referenced
this pull request
Jan 8, 2026
Replace direct chrono dependency with DateTime/DateTimeExt from apalis-sql, enabling support for both chrono and time datetime libraries via feature flags. Changes: - Add `chrono` (default) and `time` feature flags - Use DateTimeExt::from_unix_timestamp instead of chrono::Utc.timestamp_opt - Update apalis dependencies to 0.7.0-rc.2 - Add migration to convert datetime columns to TIMESTAMP - Move chrono to dev-dependencies (only needed for tests/examples) Related: apalis-dev/apalis#655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds feature flags for
chrono(default) andtimecrate support in apalis-sql.See https://github.com/orgs/apalis-dev/discussions/649
Changes
SqlDateTimetype alias that resolves based on enabled featureSqlDateTimeExttrait withnow(),to_unix_timestamp(),from_unix_timestamp()Usage