feat: add optional time crate support #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a newtype wrapper MysqlDateTime that implements SqlTimestamp from apalis-sql, enabling support for both chrono and time datetime crates via feature flags. When both are enabled, time takes precedence (matching sqlx behavior). - Add chrono/time feature flags (chrono is default) - Make datetime dependencies optional - Add timestamp module with MysqlDateTime wrapper and helper functions
Replace direct chrono usage with MysqlDateTime wrapper throughout the codebase to support both chrono and time datetime crates. - Use timestamp module functions (now, from_unix_timestamp) instead of direct chrono calls - Update TaskRow to use generic MysqlDateTime type parameter - Update TaskResult to use default type parameter - Remove deprecated get_queue method from Backend impl - Update SqlContext usage (no longer generic over pool type)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MysqlDateTimewrapper implementingSqlTimestamptimecrate support alongside defaultchronoRef: apalis-dev/apalis#654, apalis-dev/apalis#649