[#2517] fix(client): IllegalReferenceCountException about ShuffleBlockInfo #2638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuston
reviewed
Oct 10, 2025
| List<ShuffleBlock> shuffleBlocks = Lists.newArrayList(); | ||
| int partitionRequireSize = 0; | ||
| for (ShuffleBlockInfo sbi : ptb.getValue()) { | ||
| if (sbi.getData().refCnt() == 0) { |
Member
There was a problem hiding this comment.
This may not safe, I think the fast fail will be better than slient sucess.
But for this case, I haven't found the root cause about this.
Collaborator
Author
Member
There was a problem hiding this comment.
yes, this PR's change looks good to me. I will take a deep look #2608 assp in this week
zuston
approved these changes
Oct 20, 2025
| List<ShuffleBlock> shuffleBlocks = Lists.newArrayList(); | ||
| int partitionRequireSize = 0; | ||
| for (ShuffleBlockInfo sbi : ptb.getValue()) { | ||
| if (sbi.getData().refCnt() == 0) { |
Member
There was a problem hiding this comment.
yes, this PR's change looks good to me. I will take a deep look #2608 assp in this week
zuston
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
IllegalReferenceCountExceptionabout ShuffleBlockInfoWhy are the changes needed?
for #2517
Does this PR introduce any user-facing change?
No.
How was this patch tested?
current UT