[Relay] add python doc for function in ir_pass #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird, I thought the env already was the second argument for |
|
@slyubomirsky it was probably lost in the sea of git branches. |
|
It is all good. |
|
If the tests pass, it looks good to me. |
tqchen
requested changes
Oct 11, 2018
python/tvm/relay/ir_pass.py
Outdated
| t: relay.Type | ||
| The type to check | ||
|
|
||
| env: relay.Environment |
There was a problem hiding this comment.
env: relay.Environment, optional
|
@tqchen I had addressed the review comment. |
tqchen
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is almost done - I have no idea what to do with check_kind.
If there is only 1 arg, it is interpreted as type.
If there is only 2 arg, the first is env, and the second is type.
what should I do? redesign the check_kind interface to has env coming last?