-
Notifications
You must be signed in to change notification settings - Fork 110
feat(deployment): add example datasets, workflows and the dockerfile for the loader image #3754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b543591 to
47f6ad7
Compare
|
@kunwp1 Can you also review this PR? |
47f6ad7 to
df90d03
Compare
kunwp1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobbai00 I reviewed your PR and left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now we keep two example workflows as hard-coded JSON in the repo. If the workflow JSON spec changes, these files can silently break. To avoid regressions, could we adopt one of these approaches?
- Generate on setup: Dynamically create the two example JSONs from the current schema or a small generator during the setup script.
- Enforce consistency in CI: Add a guard that fails when the JSON spec (or template) changes without updating the example workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add brief docs for each setup script: what it does and when to run it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Overview
This PR introduces a set of example workflows and datasets, as well as the dockerfile for building an image to load these data. This image is being used to load example data since April 2025 but is separately managed in another repo. Adding it to the main repo can make it easier to manage, and we can later curate more example datasets and workflows.
Changes
texera-example-data-loader.dockerfile