-
Notifications
You must be signed in to change notification settings - Fork 16.3k
feat(table): Export table data with "Search box" enabled #36281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AoLiGei1221
wants to merge
18
commits into
apache:master
Choose a base branch
from
wben1998:feature/export-current-view-table
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
708206d
feat: Add the submenu called Export Current View UI
AoLiGei1221 ddfa510
feat: Add the option of exporting csv for the current view submenu
AoLiGei1221 8264a1a
feat: Update the core functionality of exporting current view table(c…
AoLiGei1221 7203c17
feat: Update the core functionality; export logic and partially displ…
AoLiGei1221 03eb3d9
feat: Update the export functionality and logic; fix type issue
RebeccaH2003 a4c6e87
update menu logic
RebeccaH2003 9baa4cf
fix: update style for useExploreAdditionalActionsMenu
AoLiGei1221 ba16b1d
fix: update the style
AoLiGei1221 605f7b0
fix: update the style
AoLiGei1221 11523d4
fix: using pre-commit fix style
AoLiGei1221 bd94787
fix: solve issues proposed by copilot
AoLiGei1221 c971ebf
fix: update style using pre-commit
AoLiGei1221 a2004e0
fix: update logic of displaying submenu and update style using pre-co…
AoLiGei1221 33cde88
fix: try to fix e2e
AoLiGei1221 209e46b
fix: cypress test modification
AoLiGei1221 19de663
fix: update test
AoLiGei1221 db04cc0
fix: miss ssh_tunnel
AoLiGei1221 0ce21f2
fix: update e2e download chart test case
AoLiGei1221 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using
as anyto add a custom behavior bypasses TypeScript's type safety. Consider either:EXPORT_CURRENT_VIEWto theBehaviorenum in@superset-ui/coreif this is intended to be a standard behavior, orThis would make the implementation more type-safe and maintainable.