fix: normalize totals cache keys for async hits #36274
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Contribution charts were getting cache misses on
force_cached=Truebecause the totals query used in post-processing kept its originalrow_limit(e.g., 1000) when building cache keys on fetch, while the cached entry was produced withrow_limit=Noneduring async computation. This mismatch could trigger unnecessary async jobs and redundant totals recalculations.This change introduces a normalization helper that always sets the totals query
row_limittoNonebefore cache-key generation, even for force-cached reads, and reuses that helper insideensure_totals_availableto avoid duplicated logic. The force-cached path now aligns cache keys without executing totals, and a unit test verifies the totals query is normalized without running a new totals query, preserving expected cache hits.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION