Skip to content

fix: activity table delta time #33503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

natilehrer
Copy link

SUMMARY

How to reproduce the bug:

  1. create new SqlQuery and save it
  2. go to home page, under 'Recents' -> 'created'
  3. see the new sqlQuery appears with wrong Modified time (see attached picture)
    this Modified time appears wrong due to different timezones

The second picture shows the fix.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

timezoneFix-before timezoneFix-after

TESTING INSTRUCTIONS

  1. create new SqlQuery and save it
  2. go to home page, under 'Recents' -> 'created'
  3. see the new sqlQuery with Modified and a few seconds/minutes
  4. change timezone in your computer/Chrome
  5. refresh superset home page
  6. verify the new sqlQuery with Modified and a few seconds/minutes still (and not hours due to timezone)
  7. repeat steps 4-6 to verify it in some more different timezones

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added global:timezone Related to timezones home:recent Related to the "recent" section of the Homepage labels May 18, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/src/features/home/ActivityTable.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@michael-s-molina michael-s-molina changed the title fixed activity table delta time fix: activity table delta time May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
global:timezone Related to timezones home:recent Related to the "recent" section of the Homepage size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant