Skip to content

feat(chart controls): Add "%d.%m.%Y" time format option #32814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

Quatters
Copy link
Contributor

SUMMARY

Implements #19618

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before After

TESTING INSTRUCTIONS

  1. Create echart, e.g. Bar Chart
  2. Go to Customize tab
  3. Search for Time Format control, check that it has new option

ADDITIONAL INFORMATION

  • Has associated issue: Add dd.mm.yyyy dateformat in superset-ui-chart-controls (Customize Tab) #19618
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the explore:control Related to the controls panel of Explore label Mar 24, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/packages/superset-ui-chart-controls/src/utils/D3Formatting.ts

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability
Design
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@sadpandajoe
Copy link
Member

@Quatters I don't think we need this as a default selectable option as a user can just type that into the field to generate the same time format.

@Quatters
Copy link
Contributor Author

@sadpandajoe this option is widely used as it's said in discussion. Isn't it a reason to add it to defaults?

@rusackas rusackas merged commit a4a0927 into apache:master Mar 31, 2025
56 checks passed
@Quatters Quatters deleted the discussions/19618-new-date-format branch March 31, 2025 07:52
alexandrusoare pushed a commit to alexandrusoare/superset that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explore:control Related to the controls panel of Explore packages size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants