feat(legend): add checkbox to display or not ALL/INV button #32346
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Remove debug console.log ▹ view | ✅ |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/plugin-chart-echarts/src/Histogram/types.ts | ✅ |
| superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-echarts/src/Histogram/controlPanel.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-echarts/src/Histogram/transformProps.ts | ✅ |
| superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
| @@ -172,3 +173,4 @@ const config: ControlPanelConfig = { | |||
| }; | |||
|
|
|||
| export default config; | |||
| console.log('✅ controlPanel.tsx is loaded! Test'); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
sadpandajoe
changed the title
| default: true, // ✅ Par défaut, les boutons sont affichés | ||
| description: t('Toggle to show/hide the "All/Invert" buttons in the legend.'), | ||
| visibility: ({ controls }: ControlPanelsContainerProps) => | ||
| Boolean(controls?.show_legend?.value), // ✅ S'affiche seulement si la légende est activée |
There was a problem hiding this comment.
It might be helpful (for most of us, anyway) to have comments in English :D
rusackas
added
the
review:checkpoint
|
Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following: Alternatively it is possible to run pre-commit by running pre-commit manually: |
|
@rusackas Ephemeral environment spinning up at http://52.13.110.49:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
@rusackas Thanks for your feedback, comments translated :P and thanks for pre-commit tips! |
sadpandajoe
removed
the
review:checkpoint
|
@rusackas HI, do you have any idea why there is error like this in jobs review (sharded-jest-tests(6)) please? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32346 +/- ##
===========================================
+ Coverage 60.48% 83.45% +22.96%
===========================================
Files 1931 546 -1385
Lines 76236 39089 -37147
Branches 8568 0 -8568
===========================================
- Hits 46114 32623 -13491
+ Misses 28017 6466 -21551
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SUMMARY
This PR introduces a new feature that allows users to toggle the visibility of the All/Invert buttons in the legend for ECharts-based visualizations.
Previously, these buttons were always displayed, but now users can enable or disable them through a new checkbox in the Chart Options panel.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
F12 > Console) for any unexpected errors related to legend rendering.✅ Expected Outcome:
ADDITIONAL INFORMATION