feat(flag flip): Setting Horizontal Filters to True by default.

[rusackas]

SUMMARY

I was a bit puzzled as to why this wasn't enable on an ephemeral environment. I think enough people are using this feature now that it ought to be on by default as part of 5.0 or a subsequent minor. I don't think this is a breaking change, but I added a note to UPDATING.md and the Feature Flags doc file accordingly.

Tagging @kgabryje @michael-s-molina @mistercrunch in case they have any feelings on controversy here :)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset/config.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[mistercrunch]

Agreed, should be the default!

[michael-s-molina]

@rusackas We had a proposal about this in 4.0 that was blocked because cross-filters worked pretty poorly with horizontal filters when compared to the vertical approach. I don't know if we had a design review since then but it would be good to check before making this the default. @kasiazjc

[sadpandajoe]

@kasiazjc For reference, this is what it'll look like with a horizontal filter bar with cross filtering:

This is for vertical:

[mistercrunch]

Oh trying to distinguish between:

• horizontal filters are ENABLED to be used
• horizontal filters are USED by default

Does the feature flag here does only 1 or 1 and 2?

[michael-s-molina]

@mistercrunch @rusackas I checked the code and this feature flag does NOT change the default which is vertical. This is a development feature flag and not a configuration feature flag. For this reason, we can delete the feature flag instead of setting it to True given that we don't need the whole process of a breaking change. For users, it would just look like we added a new feature that allows to change the filter bar orientation.

[rusackas]

@michael-s-molina works for me, if it works for you. Indeed, enabling OR deleting the flag adds the feature. If we don't perceive ords wanting to disable the feature, I'm 100% happy to delete it :) Revision coming soon...