-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Dropdown): Migrate Dropdown to Ant Design 5 #31972
refactor(Dropdown): Migrate Dropdown to Ant Design 5 #31972
Conversation
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
27c2069
to
5bb1d2c
Compare
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
Outdated
Show resolved
Hide resolved
Oh interesting... I'm on sha 6b62b6 ( I double checked, I can repro this issue on any dashboard. The actions connected to those buttons work fine though |
That was regression. Fixed it now!
Yes, that was the same on master as well.
This was also present in master
Yeah, that one i am not sure what can cause the behaviour difference as i can't reproduce it. I appreciate the detailed review and testing. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking @msyavuz and thank you for this HUGE pull request! That's really impressive amount of work and some nice refactors too 😄
@rusackas @eschutho @sadpandajoe @betodealmeida Could one of you take a look at this PR as well? We need a stamp from a code owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUMMARY
Migrate Dropdown to Ant Design 5
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:


After:


TESTING INSTRUCTIONS
Check for visual changes manually
ADDITIONAL INFORMATION