Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Dropdown): Migrate Dropdown to Ant Design 5 #31972

Merged
merged 68 commits into from
Feb 7, 2025

Conversation

msyavuz
Copy link
Contributor

@msyavuz msyavuz commented Jan 23, 2025

SUMMARY

Migrate Dropdown to Ant Design 5

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image
image

After:
image
image

TESTING INSTRUCTIONS

Check for visual changes manually

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Ant Design 5: Upgrade Dropdown component #31952
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

korbit-ai bot commented Jan 23, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@msyavuz msyavuz force-pushed the msyavuz/refactor/migrate-dropdown branch from 27c2069 to 5bb1d2c Compare January 29, 2025 10:33
@geido geido added the preset:bounty Issues that have been selected by Preset and have a bounty attached. label Jan 29, 2025
@msyavuz msyavuz requested a review from kgabryje February 7, 2025 08:33
@kgabryje
Copy link
Member

kgabryje commented Feb 7, 2025

In dashboard menu, submenu Download, both menu items get highlighted when I hover over one of them. Other menus and submenus don't have that bug.

image

@msyavuz
Copy link
Contributor Author

msyavuz commented Feb 7, 2025

Are you on the branch latest? I remember fixing that bug and it seems to be working

image

@kgabryje
Copy link
Member

kgabryje commented Feb 7, 2025

Not sure if it was like that before, but any chance we could make it stay in 1 line? Or if it needs to wrap, make it stay in the column with text and not go into the column with icons? If it's not a regression, we can fix it in a separate PR

image

@kgabryje
Copy link
Member

kgabryje commented Feb 7, 2025

Is the filter bar orientation submenu supposed to be a different color?

image

@kgabryje
Copy link
Member

kgabryje commented Feb 7, 2025

Again, not sure if it's present on master or not, but we shouldn't display a divider here if there's only "Set up report" button available (both in Explore and Dashboard)

image

@kgabryje
Copy link
Member

kgabryje commented Feb 7, 2025

In dashboard menu, submenu Download, both menu items get highlighted when I hover over one of them. Other menus and submenus don't have that bug.

image

Similar issue in Explore:

image

@kgabryje
Copy link
Member

kgabryje commented Feb 7, 2025

Are you on the branch latest? I remember fixing that bug and it seems to be working

Oh interesting... I'm on sha 6b62b6 (fix(test): change the role)

I double checked, I can repro this issue on any dashboard. The actions connected to those buttons work fine though

@msyavuz
Copy link
Contributor Author

msyavuz commented Feb 7, 2025

Not sure if it was like that before, but any chance we could make it stay in 1 line? Or if it needs to wrap, make it stay in the column with text and not go into the column with icons? If it's not a regression, we can fix it in a separate PR

That was regression. Fixed it now!

Is the filter bar orientation submenu supposed to be a different color?

Yes, that was the same on master as well.

Again, not sure if it's present on master or not, but we shouldn't display a divider here if there's only "Set up report" button available (both in Explore and Dashboard)

This was also present in master

Oh interesting... I'm on sha 6b62b6 (fix(test): change the role)
I double checked, I can repro this issue on any dashboard. The actions connected to those buttons work fine though

Yeah, that one i am not sure what can cause the behaviour difference as i can't reproduce it.

I appreciate the detailed review and testing. Thanks!

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking @msyavuz and thank you for this HUGE pull request! That's really impressive amount of work and some nice refactors too 😄
@rusackas @eschutho @sadpandajoe @betodealmeida Could one of you take a look at this PR as well? We need a stamp from a code owner

@kgabryje
Copy link
Member

kgabryje commented Feb 7, 2025

@msyavuz I think I fixed this flaky DatabaseModal test in PR #30903 which I just merged. Could you rebase onto master and we'll see if the CI passes?

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for all the hard work!

@kgabryje kgabryje merged commit bcc61bd into apache:master Feb 7, 2025
48 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend frontend:refactor:antd5 preset:bounty Issues that have been selected by Preset and have a bounty attached. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ant Design 5: Upgrade Dropdown component
6 participants