[SPARK-55910][SQL][TESTS][FOLLOW-UP] Inline unnecessary asInstanceOf[classic.SparkSession] cast in QueryTest#55715
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
…ion] cast in QueryTest
HyukjinKwon
approved these changes
May 6, 2026
zhengruifeng
changed the title
zhengruifeng
added a commit
that referenced
this pull request
May 7, 2026
…classic.SparkSession] cast in QueryTest ### What changes were proposed in this pull request? In `QueryTest.withQueryExecutionsCaptured`, the local alias `classicSession = spark.asInstanceOf[classic.SparkSession]` is replaced with direct uses of `spark`. The cast is not needed: `sparkContext` (`api/SparkSession.scala:72`) and `listenerManager` (`api/SparkSession.scala:144`) are both declared on the abstract `org.apache.spark.sql.SparkSession`, so they are accessible without converting to the classic implementation. ### Why are the changes needed? Cleanup follow-up to #55339, which removed unnecessary `asInstanceOf[classic.Dataset]` casts in `QueryTest`. The same criterion applies here: when the called API is already on the abstract type, the explicit classic cast adds noise and obscures which code paths actually depend on classic-only functionality. ### Does this PR introduce _any_ user-facing change? No. Test-only. ### How was this patch tested? `build/sbt sql/Test/compile` succeeds. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.7) Closes #55715 from zhengruifeng/inline-classic-cast-query-test. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com> (cherry picked from commit 1241434) Signed-off-by: Ruifeng Zheng <ruifengz@foxmail.com>
Contributor
Author
|
merged to master/4.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
QueryTest.withQueryExecutionsCaptured, the local aliasclassicSession = spark.asInstanceOf[classic.SparkSession]is replaced with direct uses ofspark. The cast is not needed:sparkContext(api/SparkSession.scala:72) andlistenerManager(api/SparkSession.scala:144) are both declared on the abstractorg.apache.spark.sql.SparkSession, so they are accessible without converting to the classic implementation.Why are the changes needed?
Cleanup follow-up to #55339, which removed unnecessary
asInstanceOf[classic.Dataset]casts inQueryTest. The same criterion applies here: when the called API is already on the abstract type, the explicit classic cast adds noise and obscures which code paths actually depend on classic-only functionality.Does this PR introduce any user-facing change?
No. Test-only.
How was this patch tested?
build/sbt sql/Test/compilesucceeds.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)