[SPARK-56737][SQL] Avoid binary-incompatible mode method on BroadcastExchangeLike#55702
Closed
viirya wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-56737][SQL] Avoid binary-incompatible mode method on BroadcastExchangeLike#55702viirya wants to merge 1 commit intoapache:masterfrom
BroadcastExchangeLike#55702viirya wants to merge 1 commit intoapache:masterfrom
Conversation
viirya
changed the title
Member
Author
dongjoon-hyun
changed the title
BroadcastExchangeLike
Member
|
cc @peter-toth , too. |
peter-toth
approved these changes
May 6, 2026
sunchao
approved these changes
May 6, 2026
Follow-up to SPARK-36082. The original change added an abstract def mode: BroadcastMode to the BroadcastExchangeLike trait so that LogicalQueryStageStrategy could distinguish null-aware from regular hashed broadcast stages. Adding an abstract method to a public trait is source- and binary-incompatible for downstream implementations. Inspect outputPartitioning instead. Every BroadcastExchangeLike must already produce BroadcastPartitioning(mode) to satisfy the BroadcastDistribution(mode) requirement on join sides, so the mode is already exposed through the existing SparkPlan contract and the new abstract method is unnecessary. Co-authored-by: Claude Code
viirya
force-pushed
the
refactor-spark-36082
branch
from
c31c15a to
b66eb6f
Compare
Member
Author
|
Note that, according to #55678 (comment), this needs to be backported to branch-4.x and branch-4.2. |
viirya
added a commit
that referenced
this pull request
May 6, 2026
…tExchangeLike` ### What changes were proposed in this pull request? SPARK-36082 added an abstract def mode: BroadcastMode to the BroadcastExchangeLike trait so that LogicalQueryStageStrategy could distinguish null-aware from regular hashed broadcast stages. Adding an abstract method to a public trait is source- and binary-incompatible for downstream implementations. Inspect outputPartitioning instead. Every BroadcastExchangeLike must already produce BroadcastPartitioning(mode) to satisfy the BroadcastDistribution(mode) requirement on join sides, so the mode is already exposed through the existing SparkPlan contract and the new abstract method is unnecessary. ### Why are the changes needed? Avoid binary-incompatible mode method on BroadcastExchangeLike. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Exist tests. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code Closes #55702 from viirya/refactor-spark-36082. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com> (cherry picked from commit de4c521) Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
viirya
added a commit
that referenced
this pull request
May 6, 2026
…tExchangeLike` ### What changes were proposed in this pull request? SPARK-36082 added an abstract def mode: BroadcastMode to the BroadcastExchangeLike trait so that LogicalQueryStageStrategy could distinguish null-aware from regular hashed broadcast stages. Adding an abstract method to a public trait is source- and binary-incompatible for downstream implementations. Inspect outputPartitioning instead. Every BroadcastExchangeLike must already produce BroadcastPartitioning(mode) to satisfy the BroadcastDistribution(mode) requirement on join sides, so the mode is already exposed through the existing SparkPlan contract and the new abstract method is unnecessary. ### Why are the changes needed? Avoid binary-incompatible mode method on BroadcastExchangeLike. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Exist tests. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code Closes #55702 from viirya/refactor-spark-36082. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com> (cherry picked from commit de4c521) Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
Member
Author
|
Merged to master, branch-4.x, branch-4.2. Thanks @dongjoon-hyun @sunchao @peter-toth |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-36082 added an abstract def mode: BroadcastMode to the BroadcastExchangeLike trait so that LogicalQueryStageStrategy could distinguish null-aware from regular hashed broadcast stages. Adding an abstract method to a public trait is source- and binary-incompatible for downstream implementations.
Inspect outputPartitioning instead. Every BroadcastExchangeLike must already produce BroadcastPartitioning(mode) to satisfy the BroadcastDistribution(mode) requirement on join sides, so the mode is already exposed through the existing SparkPlan contract and the new abstract method is unnecessary.
Why are the changes needed?
Avoid binary-incompatible mode method on BroadcastExchangeLike.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exist tests.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code