Skip to content

Conversation

@jaceklaskowski
Copy link
Contributor

@jaceklaskowski jaceklaskowski commented Jan 4, 2026

What changes were proposed in this pull request?

Fix markdown issues reported by rumdl check.

Fixes https://issues.apache.org/jira/browse/SPARK-54895

Why are the changes needed?

This single markdown page can pave the way towards "better docs". One file at a time.

After the changes, there are no errors reported:

$ rumdl check declarative-pipelines-programming-guide.md

Success: No issues found in 1 file (28ms)

Does this PR introduce any user-facing change?

No

How was this patch tested?

Local preview in Visual Code.

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

JIRA Issue Information

=== Improvement SPARK-54895 ===
Summary: [SDP][DOCS] Fix markdown issues in Spark Declarative Pipelines Programming Guide
Assignee: None
Status: Open
Affected: ["4.2.0"]


This comment was automatically generated by GitHub Actions

@github-actions github-actions bot added the DOCS label Jan 4, 2026
@jaceklaskowski
Copy link
Contributor Author

@sryza Mind reviewing 🙏

@jaceklaskowski
Copy link
Contributor Author

@sryza Could you review the PR? 🙏

## What is Spark Declarative Pipelines (SDP)?

Spark Declarative Pipelines (SDP) is a declarative framework for building reliable, maintainable, and testable data pipelines on Apache Spark. SDP simplifies ETL development by allowing you to focus on the transformations you want to apply to your data, rather than the mechanics of pipeline execution.
<!-- rumdl-disable MD013 -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we follow this convention in other md files? Given that the target for this content is the docs site, and the docs site wraps text, I think in general it would be better to use a ruleset that allows docs authors to write paragraphs than to try to fit inside arbitrary line length boundaries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we follow this convention in other md files?

Likely no. No idea. We could introduce a precedence that eventually could become a rule across the whole docs (it does not hurt either way, does it?).

More importantly, I didn't mean to change all the pages atm (and acquiring a single person's PoV (i.e., you)). I'd not be surprised if people didn't care about such tiny bits 🤷

- `saveAsTable()`
- `start()`
- `toTable()`
* `collect()`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are asterixes the convention that's used most widely in other docs pages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but asterisks seemed recommended (over dashes) by rumdl.

@jaceklaskowski jaceklaskowski requested a review from sryza January 11, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants