Skip to content

[SPARK-45846][SQL] optimizeNullAwareAntiJoin should respect autoBroadcastJoinThreshold #53670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
callmepandey wants to merge 1 commit into from
Closed

[SPARK-45846][SQL] optimizeNullAwareAntiJoin should respect autoBroadcastJoinThreshold #53670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,8 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
.getOrElse(createJoinWithoutHint())
}

case j @ ExtractSingleColumnNullAwareAntiJoin(leftKeys, rightKeys) =>
case j @ ExtractSingleColumnNullAwareAntiJoin(leftKeys, rightKeys)
if canBroadcastBySize(j.right, conf) =>
Seq(joins.BroadcastHashJoinExec(leftKeys, rightKeys, LeftAnti, BuildRight,
None, planLater(j.left), planLater(j.right), isNullAwareAntiJoin = true))

Expand Down
16 changes: 16 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,6 +1271,22 @@ class JoinSuite extends QueryTest with SharedSparkSession with AdaptiveSparkPlan
}
}

test("SPARK-45846: optimizeNullAwareAntiJoin should respect autoBroadcastJoinThreshold") {
withSQLConf(SQLConf.OPTIMIZE_NULL_AWARE_ANTI_JOIN.key -> "true",
SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") {
// When broadcast is disabled, null-aware anti-join should not use BroadcastHashJoinExec
val df = sql("select * from testData where key not in (select a from testData2)")
val physical = df.queryExecution.sparkPlan
// Collect all BroadcastHashJoinExec nodes
val broadcastHashJoins = collect(physical) {
case j: BroadcastHashJoinExec => j
}
// Verify no BroadcastHashJoinExec with isNullAwareAntiJoin is used
assert(broadcastHashJoins.forall(!_.isNullAwareAntiJoin),
"Null-aware anti-join should not use BroadcastHashJoinExec when broadcast is disabled")
}
}

test("SPARK-32399: Full outer shuffled hash join") {
val inputDFs = Seq(
// Test unique join key
Expand Down