[SPARK-54449][CORE] Storage Memory off heap size should be considered only when off heap is enabled #53383
+39
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VindhyaG
changed the title
VindhyaG
changed the title
VindhyaG
force-pushed
the
SPARK-54449
branch
2 times, most recently
from
095d819 to
db76a5d
Compare
VindhyaG
force-pushed
the
SPARK-54449
branch
2 times, most recently
from
dde0469 to
7f06280
Compare
VindhyaG
force-pushed
the
SPARK-54449
branch
from
7f06280 to
c701ee2
Compare
Contributor
Author
|
@holdenk can you please help review this or help tag the relevant reviewers please ? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, even if spark.memory.offHeap.enabled=false
spark.memory.offHeap.size is calculated for SPARK UI and wherever the config is used. This PR changes the logic to take the value set in spark.memory.offHeap.size only when spark.memory.offHeap.enabled
Why are the changes needed?
Change the logic to get the config of spark.memory.offHeap.size by checking spark.memory.offHeap.enabled first
Does this PR introduce any user-facing change?
Yes. Spark UI will show the total of Onheap and Off heap memory only if spark.memory.offHeap.enabled = true.
How was this patch tested?
Existing UTs
Was this patch authored or co-authored using generative AI tooling?
No