[SPARK-54442][SQL][FOLLOWUP] Add codegen for TIME numeric conversion functions #53370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinodkc
changed the title
Member
|
cc @cloud-fan |
cloud-fan
reviewed
Dec 8, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 8, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 9, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 9, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 9, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 9, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Dec 10, 2025
cloud-fan
reviewed
Dec 10, 2025
vinodkc
force-pushed
the
br_time_numeric_conversion_followup
branch
3 times, most recently
from
f921fcf to
ec99c46
Compare
cloud-fan
reviewed
Dec 11, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
Show resolved
Hide resolved
vinodkc
force-pushed
the
br_time_numeric_conversion_followup
branch
from
ec99c46 to
6f005b2
Compare
vinodkc
force-pushed
the
br_time_numeric_conversion_followup
branch
from
6f005b2 to
50e6885
Compare
cloud-fan
approved these changes
Dec 15, 2025
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implemented whole-stage codegen for TIME conversion functions (IntegralToTimeBase, TimeFromSeconds, TimeToSeconds) by removing CodegenFallback
Why are the changes needed?
Performance: CodegenFallback is 10-50x slower than generated code
Pattern consistency: Follows existing Spark patterns (IntegralToTimestampBase)
Does this PR introduce any user-facing change?
No. performance optimization with identical results.
How was this patch tested?
All existing tests pass
Generated code inspection confirms optimizations
Was this patch authored or co-authored using generative AI tooling?
No