[SPARK-53966][CORE][FOLLOWUP] Support is(Serial|Parallel)GC
#52708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests passed. Could you review this PR, @sarutak ? |
sarutak
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
LGTM. I'll merge this into master.
Thank you @dongjoon-hyun !
|
Thank you. Yes, please, @sarutak ! |
|
Late LGTM, and thanks for informing me, @dongjoon-hyun |
Yicong-Huang
pushed a commit
to Yicong-Huang/spark
that referenced
this pull request
Oct 30, 2025
### What changes were proposed in this pull request? This PR aims to support `isSerialGC` and `isParallelGC` additionally as a follow-up of the following PR. - apache#52678 ### Why are the changes needed? - To be exhaustive (up to Java 25 environment) - Note that `UseEpsilonGC` is excluded because it's not a production-purpose GC. ### Does this PR introduce _any_ user-facing change? No, these are new APIs. ### How was this patch tested? Pass the CIs and manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52708 from dongjoon-hyun/SPARK-53966. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
isSerialGCandisParallelGCadditionally as a follow-up of the following PR.Why are the changes needed?
UseEpsilonGCis excluded because it's not a production-purpose GC.Does this PR introduce any user-facing change?
No, these are new APIs.
How was this patch tested?
Pass the CIs and manual review.
Was this patch authored or co-authored using generative AI tooling?
No.