[SPARK-52762][SDP] Add PipelineAnalysisContext message to support pipeline analysis during Spark Connect query execution #52685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookiedough77
changed the title
cookiedough77
changed the title
sryza
changed the title
sryza
changed the title
sryza
reviewed
Oct 22, 2025
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto
Outdated
Show resolved
Hide resolved
cookiedough77
changed the title
sryza
reviewed
Oct 22, 2025
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto
Outdated
Show resolved
Hide resolved
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto
Outdated
Show resolved
Hide resolved
| optional string dataflow_graph_id = 1; | ||
|
|
||
| // Defines the path assigned at runtime when the pipeline initializes | ||
| optional string definition_path = 2; |
There was a problem hiding this comment.
We determined that we need a corresponding field on SourceCodeLocation, right? Also, perhaps we should give this consistent naming with the file_name field there? Perhaps outer_file_name?
There was a problem hiding this comment.
Discussed to be definition_path. added to SourceCodeLocation.
sryza
changed the title
sryza
changed the title
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Oct 27, 2025
…th `4.1.0-preview3` RC1 ### What changes were proposed in this pull request? This PR aims to update Spark Connect-generated Swift source code with Apache Spark `4.1.0-preview3` RC1. ### Why are the changes needed? There are many changes between Apache Spark 4.1.0-preview2 and preview3. - apache/spark#52685 - apache/spark#52613 - apache/spark#52553 - apache/spark#52532 - apache/spark#52517 - apache/spark#52514 - apache/spark#52487 - apache/spark#52328 - apache/spark#52200 - apache/spark#52154 - apache/spark#51344 To use the latest bug fixes and new messages to develop for new features of `4.1.0-preview3`. ``` $ git clone -b v4.1.0-preview3 https://github.com/apache/spark.git $ cd spark/sql/connect/common/src/main/protobuf/ $ protoc --swift_out=. spark/connect/*.proto $ protoc --grpc-swift_out=. spark/connect/*.proto // Remove empty GRPC files $ cd spark/connect $ grep 'This file contained no services' * | awk -F: '{print $1}' | xargs rm ``` ### Does this PR introduce _any_ user-facing change? Pass the CIs. ### How was this patch tested? Pass the CIs. I manually tested with `Apache Spark 4.1.0-preview3` (with the two SDP ignored tests). ``` $ swift test --no-parallel ... ✔ Test run with 203 tests in 21 suites passed after 19.088 seconds. ``` ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #252 from dongjoon-hyun/SPARK-54043. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces a new protobuf message, PipelineAnalysisContext, in ect/common/src/main/protobuf/spark/connect/pipelines.proto.
Why are the changes needed?
Special handling is needed for spark.sql in certain contexts. This proto provides a foundation for passing such context in future.
Does this PR introduce any user-facing change?
No, it only adds an internal protobuf message.
How was this patch tested?
Verified through protobuf compilation and existing test coverage.
Was this patch authored or co-authored using generative AI tooling?
No.