[SPARK-53957][Geo][SQL] Support GEOGRAPHY and GEOMETRY in the SpatialReferenceSystemMapper #52667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
changed the title
uros-db
commented
Oct 20, 2025
mkaravel
reviewed
Oct 24, 2025
...rc/main/scala/org/apache/spark/sql/internal/types/CartesianSpatialReferenceSystemMapper.java
Outdated
Show resolved
Hide resolved
...rc/main/scala/org/apache/spark/sql/internal/types/CartesianSpatialReferenceSystemMapper.java
Outdated
Show resolved
Hide resolved
...c/main/scala/org/apache/spark/sql/internal/types/GeographicSpatialReferenceSystemMapper.java
Outdated
Show resolved
Hide resolved
...c/main/scala/org/apache/spark/sql/internal/types/GeographicSpatialReferenceSystemMapper.java
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/internal/types/SpatialReferenceSystemCache.java
Outdated
Show resolved
Hide resolved
mkaravel
approved these changes
Oct 24, 2025
|
@cloud-fan Please review. |
|
@cloud-fan This one should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extend the
SpatialReferenceSystemMapperclass to offer SRID <-> CRS mappings for bothGeographyTypeandGeometryType.The
SpatialReferenceSystemMapperclass was introduced originally as part of: #52491.Why are the changes needed?
Avoid manual checks for GEOGRAPHY type, and use the centralized SRS mapping logic.
Also, this PR will make it easier to support additional SRID/CRS values for spatial types soon.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added new tests to:
SpatialReferenceSystemMapperSuiteWas this patch authored or co-authored using generative AI tooling?
No.