[SPARK-51415][SQL] Support the time type by make_timestamp() #51543
+2,918
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
changed the title
uros-db
changed the title
MaxGekk
requested changes
Jul 21, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
Outdated
Show resolved
Hide resolved
|
cc @yaooqinn @LuciferYang @cloud-fan since you reviewed my PR: #51179 |
cloud-fan
reviewed
Jul 22, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
MaxGekk
reviewed
Jul 23, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modify the
make_timestampfunction to create a timestamp from date and time (and optional timezone).Arguments
date: A date expressiontime: A time expressionReturns
Examples
Why are the changes needed?
Users will be able to create a timestamp with (or without time zone) by using a date and time inputs.
Does this PR introduce any user-facing change?
Yes, it adds new SQL function syntax support.
How was this patch tested?
New unit tests for timestamp calculation, catalyst expression level unit tests with & without codegen, Scala function unit tests, e2e SQL tests / golden files in both ANSI and non-ANSI modes.
Was this patch authored or co-authored using generative AI tooling?
No.