[SPARK-51687][SQL] Pushdown filters with TIME values to parquet #50473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
MaxGekk
changed the title
MaxGekk
requested review from
LuciferYang,
HyukjinKwon,
yaooqinn,
beliefer and
dongjoon-hyun
yaooqinn
approved these changes
Apr 2, 2025
|
Merging to master. Thank you, @yaooqinn for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to support pushdown filters over TIME columns in the parquet datasource. In particular, pushdown the following operators:
===, <=>, =!=, isNull, isNotNull, >, >=, <, <=.Why are the changes needed?
The PR #50389 supported the TIME type in the Parquet datasource as INT64 but filters with such values are not pushed down. So, comparing to primitive types, the TIME type can suffer from worse performance in read. This PR aims to solve the issue, and achieve feature parity with other types.
Does this PR introduce any user-facing change?
No, the changes might influence on performance of the parquet datasource only.
How was this patch tested?
By running new tests in
ParquetFilterSuite:Was this patch authored or co-authored using generative AI tooling?
No.