[SPARK-51596][SS] Fix concurrent StateStoreProvider maintenance and closing #50391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasnain-db
reviewed
Apr 9, 2025
| ) | ||
| // Make maintenance interval very large (30s) so that task thread runs before maintenance. | ||
| sqlConf.setConf(SQLConf.STREAMING_MAINTENANCE_INTERVAL, 30000L) | ||
| // Use the `MaintenanceErrorOnCertainPartitionsProvider` to run the test |
There was a problem hiding this comment.
nit - this seems copied from below -- this should now be FakeStateStoreProviderTracksCloseThread right?
|
|
||
| withSpark(SparkContext.getOrCreate(conf)) { sc => | ||
| withCoordinatorRef(sc) { coordinatorRef => | ||
| val rootLocation = s"${Utils.createTempDir().getAbsolutePath}/spark-48997" |
There was a problem hiding this comment.
nit
Suggested change
| val rootLocation = s"${Utils.createTempDir().getAbsolutePath}/spark-48997" | |
| val rootLocation = s"${Utils.createTempDir().getAbsolutePath}/spark-51596" |
|
Replicated by #50595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Moves the unload operation away from task thread into the maintenance thread. To ensure unloading still occurs ASAP (rather than potentially waiting for the maintenance interval) as was introduced by https://issues.apache.org/jira/browse/SPARK-33827, we immediately trigger a maintenance thread to do the unload.
This gives us an extra benefit that unloading other providers doesn't block the task thread. To capitalize on this, unload() should not hold the loadedProviders lock the entire time (which will block other task threads), but instead release it once it has deleted the unloading providers from the map and close the providers without the lock held.
Why are the changes needed?
Currently, both the task thread and maintenance thread can call unload() on a provider. This leads to a race condition where the maintenance could be conducting maintenance while the task thread is closing the provider, leading to unexpected behavior.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added unit test
Was this patch authored or co-authored using generative AI tooling?
No