[SPARK-51404][SQL] Parse the time(n) type as TimeType(n)
#50384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
time(n) type as TimeType(n)time(n) type as TimeType(n)
MaxGekk
requested review from
LuciferYang,
yaooqinn,
beliefer and
dongjoon-hyun
|
Merging to master. Thank you, @LuciferYang for review. |
kazemaksOG
pushed a commit
to kazemaksOG/spark-custom-scheduler
that referenced
this pull request
Mar 27, 2025
### What changes were proposed in this pull request? Support parsing `time(n)` as `TimeType(n)` in schema JSON or DDL string. It also add tests for parsing "time(n)" in JSON/DDL. ### Why are the changes needed? The changes is required by other parts of Spark SQL to support new data type. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the modified test suite: ``` $ build/sbt "test:testOnly *DataTypeSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50384 from MaxGekk/time-type-parser. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support parsing
time(n)asTimeType(n)in schema JSON or DDL string. It also add tests for parsing "time(n)" in JSON/DDL.Why are the changes needed?
The changes is required by other parts of Spark SQL to support new data type.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test suite:
Was this patch authored or co-authored using generative AI tooling?
No.