[SPARK-51583] [SQL] Improve error message when to_timestamp function has arguments of wrong type #50347
Conversation
| e.invalidFormat(checkRes) | ||
| } | ||
|
|
||
| case parseToTimestamp: ParseToTimestamp if parseToTimestamp.left.dataType != StringType => |
There was a problem hiding this comment.
ParseToTimestamp should support numeric, see #35887. cc @HyukjinKwon
And I am not sure that checking parameters of particular expression here in checkAnalysis is right approach. IMHO, ParseToTimestamp should care of them.
There was a problem hiding this comment.
Can we do it in checkInputDataTypes or inputTypes in ParseToTimestamp?
There was a problem hiding this comment.
Hmm, I just wonder what's the semantics here: should we support NumericTypes here or no? cc @srielau
Per docs, it seems that we should support STRING type only.
There was a problem hiding this comment.
I think the problem is that it is a breaking change .. I would leave it to @srielau tho.
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
3 participants
What changes were proposed in this pull request?
I propose that we fix error message when to_timestamp function is called with improper argument types.
Why are the changes needed?
Users are provided with more user facing error instead of an internal one, which is more correct.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added test.
Was this patch authored or co-authored using generative AI tooling?
No.