[SPARK-51497][SQL] Add the default time formatter #50266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
MaxGekk
changed the title
MaxGekk
requested review from
LuciferYang,
yaooqinn,
beliefer and
dongjoon-hyun
dongjoon-hyun
approved these changes
Mar 13, 2025
|
late LGTM, Thank you @MaxGekk |
anoopj
pushed a commit
to anoopj/spark
that referenced
this pull request
Mar 15, 2025
### What changes were proposed in this pull request? In the PR, I propose to add new time formatter `DefaultTimeFormatter` which behaves like `CAST` in parsing, and uses the default pattern in formatting. ### Why are the changes needed? The default time formatter can be used in the situation when time pattern is unknown or not set like in text datasources, partition discovery, time expressions and so on. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running new test: ``` $ build/sbt "test:testOnly *TimeFormatterSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50266 from MaxGekk/to_time. Authored-by: Max Gekk <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to add new time formatter
DefaultTimeFormatterwhich behaves likeCASTin parsing, and uses the default pattern in formatting.Why are the changes needed?
The default time formatter can be used in the situation when time pattern is unknown or not set like in text datasources, partition discovery, time expressions and so on.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running new test:
Was this patch authored or co-authored using generative AI tooling?
No.