[SPARK-51482][SQL] Support cast from string to time #50236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
MaxGekk
changed the title
|
@yaooqinn @LuciferYang @dongjoon-hyun @HyukjinKwon Could you take a look at the PR when you have time, please. |
LuciferYang
reviewed
Mar 12, 2025
| } else { | ||
| code""" | ||
| scala.Option<Long> $longOpt = | ||
| org.apache.spark.sql.catalyst.util.DateTimeUtils.stringToTime($c); |
There was a problem hiding this comment.
Can also use $dateTimeUtilsCls.stringToTime($c); ?
There was a problem hiding this comment.
Fixed, and changed other places too. Please, review the PR: #50251
| } | ||
|
|
||
| case _ => | ||
| (_, evPrim, evNull) => code"$evNull = true;" |
There was a problem hiding this comment.
Suggested change
| (_, evPrim, evNull) => code"$evNull = true;" | |
| (_, _, evNull) => code"$evNull = true;" |
LuciferYang
approved these changes
Mar 12, 2025
|
Merging to master. Thank you, @LuciferYang @beliefer for review. |
anoopj
pushed a commit
to anoopj/spark
that referenced
this pull request
Mar 15, 2025
### What changes were proposed in this pull request?
In the PR, I propose to support `CAST` from `STRING` to `TIME(n)`. The format of input strings should match to:
```
[h]h:[m]m:[s]s.[ms][ms][ms][us][us][us]
```
### Why are the changes needed?
Before the changes, such casting allowed by the SQL standard failed w/ the error:
```scala
scala> Seq("17:18:19").toDS.select($"value".cast(TimeType())).show()
org.apache.spark.sql.catalyst.ExtendedAnalysisException: [DATATYPE_MISMATCH.CAST_WITHOUT_SUGGESTION] Cannot resolve "CAST(value AS TIME(6))" due to data type mismatch: cannot cast "STRING" to "TIME(6)". SQLSTATE: 42K09;
```
### Does this PR introduce _any_ user-facing change?
Yes. After the changes, the cast above works as expected:
```scala
scala> Seq("17:18:19").toDS.select($"value".cast(TimeType())).show()
+--------+
| value|
+--------+
|17:18:19|
+--------+
```
### How was this patch tested?
By running the new tests:
```
$ build/sbt "test:testOnly *CastWithAnsiOffSuite"
$ build/sbt "test:testOnly *CastWithAnsiOnSuite"
```
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#50236 from MaxGekk/string-to-time.
Authored-by: Max Gekk <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to support
CASTfromSTRINGtoTIME(n). The format of input strings should match to:Why are the changes needed?
Before the changes, such casting allowed by the SQL standard failed w/ the error:
Does this PR introduce any user-facing change?
Yes. After the changes, the cast above works as expected:
How was this patch tested?
By running the new tests:
Was this patch authored or co-authored using generative AI tooling?
No.