[SPARK-51454][SQL] Support cast from time to string #50224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
MaxGekk
changed the title
dongjoon-hyun
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
+1, LGTM. Thank you, @MaxGekk .
Merged to master for Apache Spark 4.1.0.
|
late LGTM |
anoopj
pushed a commit
to anoopj/spark
that referenced
this pull request
Mar 15, 2025
### What changes were proposed in this pull request?
In the PR, I propose to support casting of TIME to STRING using the fraction formatter which formats times according to the pattern `HH:mm:ss.[..fff..]`. The pattern `[..fff..]` is a fraction of second up to microsecond resolution. The formatter does not output trailing zeros in the fraction. Apparently the `ToPrettyString` expression and `.show()` support such casting too.
Also the PR adds the support of TIME literals created from `java.time.LocalTime` (used it tests).
### Why are the changes needed?
To output time values in user friendly format. Before the changes, show prints internal representation of time values:
```scala
scala> Seq(LocalTime.parse("17:18:19")).toDS.show()
+-----------+
| value|
+-----------+
|62299000000|
+-----------+
```
### Does this PR introduce _any_ user-facing change?
Yes. After the changes, the command above outputs time values in new format:
```scala
scala> Seq(LocalTime.parse("17:18:19")).toDS.show()
+--------+
| value|
+--------+
|17:18:19|
+--------+
```
### How was this patch tested?
By running new tests:
```
$ build/sbt "test:testOnly *ToPrettyStringSuite"
$ build/sbt "test:testOnly *CastWithAnsiOnSuite"
```
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#50224 from MaxGekk/time-cast-to-string.
Authored-by: Max Gekk <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
|
Missed out on this PR. Late LGTM! |
kazemaksOG
pushed a commit
to kazemaksOG/spark-custom-scheduler
that referenced
this pull request
Mar 27, 2025
### What changes were proposed in this pull request?
In the PR, I propose to support casting of TIME to STRING using the fraction formatter which formats times according to the pattern `HH:mm:ss.[..fff..]`. The pattern `[..fff..]` is a fraction of second up to microsecond resolution. The formatter does not output trailing zeros in the fraction. Apparently the `ToPrettyString` expression and `.show()` support such casting too.
Also the PR adds the support of TIME literals created from `java.time.LocalTime` (used it tests).
### Why are the changes needed?
To output time values in user friendly format. Before the changes, show prints internal representation of time values:
```scala
scala> Seq(LocalTime.parse("17:18:19")).toDS.show()
+-----------+
| value|
+-----------+
|62299000000|
+-----------+
```
### Does this PR introduce _any_ user-facing change?
Yes. After the changes, the command above outputs time values in new format:
```scala
scala> Seq(LocalTime.parse("17:18:19")).toDS.show()
+--------+
| value|
+--------+
|17:18:19|
+--------+
```
### How was this patch tested?
By running new tests:
```
$ build/sbt "test:testOnly *ToPrettyStringSuite"
$ build/sbt "test:testOnly *CastWithAnsiOnSuite"
```
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes apache#50224 from MaxGekk/time-cast-to-string.
Authored-by: Max Gekk <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to support casting of TIME to STRING using the fraction formatter which formats times according to the pattern
HH:mm:ss.[..fff..]. The pattern[..fff..]is a fraction of second up to microsecond resolution. The formatter does not output trailing zeros in the fraction. Apparently theToPrettyStringexpression and.show()support such casting too.Also the PR adds the support of TIME literals created from
java.time.LocalTime(used it tests).Why are the changes needed?
To output time values in user friendly format. Before the changes, show prints internal representation of time values:
Does this PR introduce any user-facing change?
Yes. After the changes, the command above outputs time values in new format:
How was this patch tested?
By running new tests:
Was this patch authored or co-authored using generative AI tooling?
No.