[SPARK-51442][SQL] Add time formatters #50190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
TimeFormatter
MaxGekk
changed the title
|
@LuciferYang @gengliangwang Could you review this PR, please. |
LuciferYang
approved these changes
Mar 9, 2025
| with DateTimeFormatterHelper { | ||
|
|
||
| @transient | ||
| protected lazy val formatter = getOrCreateFormatter(pattern, locale, isParsing) |
There was a problem hiding this comment.
nit: for a protected field, readability might be improved if a type declaration could be added.
| isParsing = false) { | ||
|
|
||
| @transient | ||
| override protected lazy val formatter = DateTimeFormatterHelper.fractionTimeFormatter |
| @@ -112,4 +112,15 @@ object DateTimeTestUtils { | |||
| result = Math.addExact(result, Math.multiplyExact(seconds, MICROS_PER_SECOND)) | |||
| result | |||
| } | |||
|
|
|||
| // Returns microseconds since midnight | |||
| def localtime( | |||
There was a problem hiding this comment.
def localtime -> def localTime
|
Merging to master. Thank you, @LuciferYang for review. |
anoopj
pushed a commit
to anoopj/spark
that referenced
this pull request
Mar 15, 2025
### What changes were proposed in this pull request? In the PR, I propose two new formatters: `Iso8601TimeFormatter` and `FractionTimeFormatter` similar to the date or timestamp formatters: - The ISO 8601 formatter is capable of formatting and parsing the ISO-8601 extended time format, - The fraction formatter is similar to the previous one but does not output trailing zeros in the fraction. ### Why are the changes needed? The datetime formatters are used in `CAST` and other parsing/formatting expressions. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running new test suite: ``` $ build/sbt "test:testOnly *TimeFormatterSuite" $ build/sbt "test:testOnly *TimestampFormatterSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50190 from MaxGekk/time-formatter. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
kazemaksOG
pushed a commit
to kazemaksOG/spark-custom-scheduler
that referenced
this pull request
Mar 27, 2025
### What changes were proposed in this pull request? In the PR, I propose two new formatters: `Iso8601TimeFormatter` and `FractionTimeFormatter` similar to the date or timestamp formatters: - The ISO 8601 formatter is capable of formatting and parsing the ISO-8601 extended time format, - The fraction formatter is similar to the previous one but does not output trailing zeros in the fraction. ### Why are the changes needed? The datetime formatters are used in `CAST` and other parsing/formatting expressions. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running new test suite: ``` $ build/sbt "test:testOnly *TimeFormatterSuite" $ build/sbt "test:testOnly *TimestampFormatterSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50190 from MaxGekk/time-formatter. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose two new formatters:
Iso8601TimeFormatterandFractionTimeFormattersimilar to the date or timestamp formatters:Why are the changes needed?
The datetime formatters are used in
CASTand other parsing/formatting expressions.Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running new test suite:
Was this patch authored or co-authored using generative AI tooling?
No.