[SPARK-51384][SQL] Support java.time.LocalTime as the external type of TimeType
#50153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
java.time.LocalTime as the external type of TimeTypejava.time.LocalTime as the external type of TimeType
MaxGekk
requested review from
gengliangwang,
LuciferYang,
cloud-fan,
yaooqinn and
dongjoon-hyun
yaooqinn
approved these changes
Mar 6, 2025
|
Merging to master. Thank you, @yaooqinn @dongjoon-hyun for review. |
Pajaraja
pushed a commit
to Pajaraja/spark
that referenced
this pull request
Mar 6, 2025
… of `TimeType` ### What changes were proposed in this pull request? In the PR, I propose to support `java.time.LocalTime` as the external type of new data type `TIME` introduced by apache#50103. After the changes, users can create Datasets with `TimeType` columns and collect them back as instances of `java.time.LocalTime`. For example: ```scala scala> val df = Seq(LocalTime.of(12, 15)).toDF val df: org.apache.spark.sql.DataFrame = [value: time(6)] scala> df.printSchema root |-- value: time(6) (nullable = true) scala> df.first.getAs[LocalTime](0) val res8: java.time.LocalTime = 12:15 ``` By default the external type is encoded to the `TIME` type column with precision = 6 (microseconds). ### Why are the changes needed? 1. To allow creation of TIME columns using public Scala/Java API otherwise new type is useless. 2. To be able to write tests when supporting new type in other parts of Spark SQL. ### Does this PR introduce _any_ user-facing change? Yes, in some sense since the PR allow to create `TimeType` columns using Scala/Java APIs. ### How was this patch tested? By running new tests: ``` $ build/sbt "test:testOnly *DateTimeUtilsSuite" $ build/sbt "test:testOnly *CatalystTypeConvertersSuite" $ build/sbt "test:testOnly *DatasetSuite" ``` and modified: ``` $ build/sbt "test:testOnly *DataTypeSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50153 from MaxGekk/time-localtime. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
anoopj
pushed a commit
to anoopj/spark
that referenced
this pull request
Mar 15, 2025
… of `TimeType` ### What changes were proposed in this pull request? In the PR, I propose to support `java.time.LocalTime` as the external type of new data type `TIME` introduced by apache#50103. After the changes, users can create Datasets with `TimeType` columns and collect them back as instances of `java.time.LocalTime`. For example: ```scala scala> val df = Seq(LocalTime.of(12, 15)).toDF val df: org.apache.spark.sql.DataFrame = [value: time(6)] scala> df.printSchema root |-- value: time(6) (nullable = true) scala> df.first.getAs[LocalTime](0) val res8: java.time.LocalTime = 12:15 ``` By default the external type is encoded to the `TIME` type column with precision = 6 (microseconds). ### Why are the changes needed? 1. To allow creation of TIME columns using public Scala/Java API otherwise new type is useless. 2. To be able to write tests when supporting new type in other parts of Spark SQL. ### Does this PR introduce _any_ user-facing change? Yes, in some sense since the PR allow to create `TimeType` columns using Scala/Java APIs. ### How was this patch tested? By running new tests: ``` $ build/sbt "test:testOnly *DateTimeUtilsSuite" $ build/sbt "test:testOnly *CatalystTypeConvertersSuite" $ build/sbt "test:testOnly *DatasetSuite" ``` and modified: ``` $ build/sbt "test:testOnly *DataTypeSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50153 from MaxGekk/time-localtime. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
kazemaksOG
pushed a commit
to kazemaksOG/spark-custom-scheduler
that referenced
this pull request
Mar 27, 2025
… of `TimeType` ### What changes were proposed in this pull request? In the PR, I propose to support `java.time.LocalTime` as the external type of new data type `TIME` introduced by apache#50103. After the changes, users can create Datasets with `TimeType` columns and collect them back as instances of `java.time.LocalTime`. For example: ```scala scala> val df = Seq(LocalTime.of(12, 15)).toDF val df: org.apache.spark.sql.DataFrame = [value: time(6)] scala> df.printSchema root |-- value: time(6) (nullable = true) scala> df.first.getAs[LocalTime](0) val res8: java.time.LocalTime = 12:15 ``` By default the external type is encoded to the `TIME` type column with precision = 6 (microseconds). ### Why are the changes needed? 1. To allow creation of TIME columns using public Scala/Java API otherwise new type is useless. 2. To be able to write tests when supporting new type in other parts of Spark SQL. ### Does this PR introduce _any_ user-facing change? Yes, in some sense since the PR allow to create `TimeType` columns using Scala/Java APIs. ### How was this patch tested? By running new tests: ``` $ build/sbt "test:testOnly *DateTimeUtilsSuite" $ build/sbt "test:testOnly *CatalystTypeConvertersSuite" $ build/sbt "test:testOnly *DatasetSuite" ``` and modified: ``` $ build/sbt "test:testOnly *DataTypeSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50153 from MaxGekk/time-localtime. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to support
java.time.LocalTimeas the external type of new data typeTIMEintroduced by #50103. After the changes, users can create Datasets withTimeTypecolumns and collect them back as instances ofjava.time.LocalTime. For example:By default the external type is encoded to the
TIMEtype column with precision = 6 (microseconds).Why are the changes needed?
Does this PR introduce any user-facing change?
Yes, in some sense since the PR allow to create
TimeTypecolumns using Scala/Java APIs.How was this patch tested?
By running new tests:
and modified:
Was this patch authored or co-authored using generative AI tooling?
No.