Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support specifying the configuration of the checkpoint collection #3278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

1995chen
Copy link

@1995chen 1995chen commented Mar 20, 2025

Description

Please provide a short description of the changes you're making with this pull request.

Solution

I changed the hardcoded parts in the code to retrieve them from user request parameters.

Tests

In the local testing environment, this parameter can be correctly passed in and received.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@1995chen
Copy link
Author

@HoustonPutman can you help me review this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant