Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17697 Use picocli instead of commons-cli #3254

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Mar 11, 2025

https://issues.apache.org/jira/browse/SOLR-17697

This PR is just a way to visualize the status of the feature branch jira/SOLR-17697-picocli.
Create PRs targeting that branch to tackle individual tasks, and then merge into this feature branch once done.

Tasks/milestones:

  • Add framework
  • Implement POC for a few initial tools, in parallel with commons-cli
  • Solve option inheritance / MixIn
  • Solve option mutual exclusivity
  • Solve value-fallback to ENV
  • Document in RefGuide - Auto generate?
  •  All tools covered
  • BATS tests green
  • Proof read Usage helps
  • Remove commons-cli

@janhoy janhoy changed the title Use picocli instead of commons-cli SOLR-17697 Use picocli instead of commons-cli Mar 11, 2025
@xtenzQ
Copy link
Contributor

xtenzQ commented Mar 21, 2025

Actually, I'd like to try to implement PoC for few initial tools.

upd: oh, I didnt notice there is a PR created for this

@janhoy
Copy link
Contributor Author

janhoy commented Mar 21, 2025

upd: oh, I didnt notice there is a PR created for this

Yea, there's an in-progress exploration taking place, feel free to join the discussion about it or POC for yourself on how to solve various issues that arise. We're still trying to land on the most elegant way to introduce things, and I plan to dial down the ambitions for the other PR to do bare minimal for one or two tools, and perhaps the "start" tool. Eventually, when we start getting the grip on how things should flow, it will be easier to jump in and implement PRs for new tools, targeting this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants