Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asciidoc errors and warnings #3196

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Fix asciidoc errors and warnings #3196

merged 2 commits into from
Feb 18, 2025

Conversation

malliaridis
Copy link
Contributor

Description

The build outputs are reporting a few issues with tables cells that are not rendered and duplicate IDs.

Solution

This PR fixes these issues by updating the duplicate IDs and adding additional cells so that the last row / cell is displayed again.

Tests

Affected pages can be reviewed in current ref guide for the missing cells / page references.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@malliaridis malliaridis requested a review from epugh February 18, 2025 23:33
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 18, 2025
epugh
epugh approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had noticed these starting to crop up, so thank you for paying attention to detail and preventing bit rot to set in too strongly!

@malliaridis malliaridis merged commit 4e98925 into apache:main Feb 18, 2025
2 of 3 checks passed
@malliaridis malliaridis deleted the bugifx/fix-asciidoc-issues branch February 18, 2025 23:53
malliaridis added a commit that referenced this pull request Feb 18, 2025
@malliaridis
Fix asciidoc errors and warnings (#3196)
2e9f815 
* Fix dropping cells from incomplete row detected end of table

* Fix id assigned to block already in use

(cherry picked from commit 4e98925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epugh epugh epugh approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malliaridis @epugh