SOLR-17641: Disable the Security Manager for Java 24+ #3153
Conversation
github-actions
bot
added
documentation
|
It's great that you made the disabling conditional on Java 24+. I wonder though if we are better served just removing it completely from Solr 10, regardless of version of Java? |
Co-authored-by: Christos Malliaridis <[email protected]>
|
Agree with @epugh - isn't Security Manager all no-ops even with 21 (which IIRC is the minimum Java for Solr 10) |
I've never heard that. Do you have a link for that? |
No, it isn't. It's fully working in 21. It gets a noop in 24 (actually Access controller). In addition, you can't configure it anymore. |
| @@ -204,6 +204,10 @@ allprojects { | |||
| if (project.ext.has("useSecurityManager")) { | |||
| useSecurityManager = project.ext.get("useSecurityManager") | |||
| } | |||
| // Solr does not run with the Security Mangager for Java 24+ | |||
There was a problem hiding this comment.
| // Solr does not run with the Security Mangager for Java 24+ | |
| // There is no longer a Security Manager in Java 24 |
| @@ -35,6 +35,8 @@ plugins { | |||
| } | |||
|
|
|||
| // Declare default Java versions for the entire project and for SolrJ separately | |||
| rootProject.ext.currentJavaVersion = JavaVersion.current() | |||
| rootProject.ext.minJavaVersionSolrJ = JavaVersion.toVersion(libs.versions.java.solrj.get()) | |||
| @@ -1155,6 +1155,11 @@ else | |||
| REMOTE_JMX_OPTS=() | |||
| fi | |||
|
|
|||
| # Do not use the java security manager when running Java 24+ | |||
| if (( JAVA_VER_NUM >= 24 )) ; then | |||
There was a problem hiding this comment.
could just combine this condition into line 1164. Ideally this changes the "true" in the default interpretation of that env var to a "false". But it's fine.
| Java removed support for the Security Manager starting with Java 24, therefore Solr will disable the feature when run with Java 24 or later. | ||
|
|
There was a problem hiding this comment.
minor: Okay but arguably you didn't have to bother to say this. There's no action for the user to take. I don't think it's up to Solr to tell people what's coming/going/happening in the Java ecosystem.
https://issues.apache.org/jira/browse/SOLR-17641